RFR: 8310192: RISC-V: Merge vector min & max instructs with similar match rules

Gui Cao gcao at openjdk.org
Fri Jun 16 12:13:01 UTC 2023


On Fri, 16 Jun 2023 10:44:59 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

> Why the removal of that comment?

Thanks for the review, this comment does not match the actual assembly logic, where the align logic of source and dst address  is judged first, not only align the source address. 
https://github.com/openjdk/jdk/blob/b412fc79c3c2548df10918090beedaf6b2d08d96/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp#L987-L993

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14510#discussion_r1232166847


More information about the hotspot-compiler-dev mailing list