RFR: 8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind

Tom Rodriguez never at openjdk.org
Mon Jun 19 02:31:14 UTC 2023


On Tue, 13 Jun 2023 08:24:23 GMT, Gergö Barany <gbarany at openjdk.org> wrote:

> `jdk.vm.ci.amd64.AMD64#getLargestStorableKind(RegisterCategory)` unconditionally returns `AMD64Kind.MASK64` for mask registers. This is only correct if the target supports AVX512BW. On other AVX512 versions this should be `MASK16`.
> 
> The Graal compiler uses this method to determine how to spill a given register. An incorrect size will lead to compilation errors due to trying to emit a move with a size that is not supported by the target. I have manually verified that this fixes those problems.

The linux-x86 failure looks unrelated so the testing looks clean to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14441#issuecomment-1596391842


More information about the hotspot-compiler-dev mailing list