RFR: 8310143: RandomCommandsTest fails due to unexpected VM exit code after JDK-8282797 [v2]

[Tobias Hartmann]

On Fri, 16 Jun 2023 15:20:50 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Set isValid properly and inside of the loop
>>  - Merge branch 'JDK-8310143' of https://github.com/TobiHartmann/jdk into JDK-8310143
>>  - 8310143: RandomCommandsTest fails due to unexpected VM exit code after JDK-8282797
>
> test/hotspot/jtreg/compiler/compilercontrol/share/MultiCommand.java line 83:
> 
>> 81:             } else {
>> 82:                 md = AbstractTestBase.METHOD_GEN.generateRandomDescriptor(exec);
>> 83:                 isValid = false;
> 
> Is there a (remote) chance that `generateRandomDescriptor()` generates a valid descriptor? Would the compiler control test fail in that case due to a "false negative" ("expected to fail but did not fail")? Maybe a clarifying comment here would help.

Yes, I think that could happen. I updated that line to use `md.isValid()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14514#discussion_r1233914640