RFR: 8301489: ShortLoopOptimizer might lift instructions before their inputs [v2]

[Daniel Skantz]

On Mon, 19 Jun 2023 05:34:47 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Daniel Skantz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/hotspot/share/c1/c1_ValueMap.cpp line 367:
> 
>> 365:   bool _valid = true;
>> 366: 
>> 367:   void visit(Value* vp) {
> 
> Since `Value` is already a pointer type, can't we use `Value v` here?

I am not sure if this is possible without changing the ValueVisitor ([ref](https://java.se.oracle.com/source/xref/jdk-jdk/jdk-open/src/hotspot/share/c1/c1_Instruction.hpp#123)) itself

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14492#discussion_r1234929080