RFR: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs [v3]

Fri Jun 23 07:09:05 UTC 2023

On Tue, 20 Jun 2023 08:32:51 GMT, Daniel Skantz <duke at openjdk.org> wrote:

>> src/hotspot/share/c1/c1_ValueMap.cpp line 367:
>> 
>>> 365:   bool _valid = true;
>>> 366: 
>>> 367:   void visit(Value* vp) {
>> 
>> Since `Value` is already a pointer type, can't we use `Value v` here?
>
> I am not sure if this is possible without changing the ValueVisitor ([ref](https://github.com/openjdk/jdk/blob/a0595761ef35c4eec8cb84326a869b9473cd5bba/src/hotspot/share/c1/c1_Instruction.hpp#L123)) itself

Right, makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14492#discussion_r1239402716