RFR: 8310264: In PhaseChaitin::Split defs and phis are leaked [v4]

Mon Jun 26 11:43:02 UTC 2023

On Mon, 26 Jun 2023 11:01:11 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> This will call the constructor, and has since C++11 I believe.  However, I'm clearly being inconsistent here and with the VectorSet change above. There's no reason that I picked brace initializer other than it being the 'modern' way: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-list
>> 
>> I'll revert this change and use regular parens to be more stylistically consistent.
>
> Looking at https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md "uniform initialization", it's OK to use.

Thanks for the background, I wasn't aware of that. I don't have a strong opinion but consistency in the same area would be nice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14530#discussion_r1242063030