RFR: 8310264: In PhaseChaitin::Split defs and phis are leaked [v4]

Vladimir Kozlov kvn at openjdk.org
Mon Jun 26 19:37:07 UTC 2023


On Mon, 26 Jun 2023 11:40:20 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Looking at https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md "uniform initialization", it's OK to use.
>
> Thanks for the background, I wasn't aware of that. I don't have a strong opinion but consistency in the same area would be nice.

Please, change to normal `()`. Using '{}' is very confusing for not modern C++ experts and affects maintainability of this code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14530#discussion_r1242671748


More information about the hotspot-compiler-dev mailing list