RFR: JDK-8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null

[Tom Rodriguez]

On Wed, 21 Jun 2023 10:26:19 GMT, David Leopoldseder <davleopo at openjdk.org> wrote:

> Fix JVMCI handling of null dynamic constants and dynamic constant errors.
> 
> For null dynamic constants, the JVMCI code was checking for `Universe::the_null_sentinel` but `ConstantPool::resolve_possibly_cached_constant_at` returns `nullptr` for null constants.
> 
> In the case of errors thrown by a bootstrap method, `ConstantPool::resolve_possibly_cached_constant_at` already propagates the `BootstrapMethodError` so there's no need to check for `tag.is_dynamic_constant_in_error()`.

Marked as reviewed by never (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14582#pullrequestreview-1498969428