RFR: 8310308: IR Framework: check for type and size of vector nodes [v2]

Christian Hagedorn chagedorn at openjdk.org
Wed Jun 28 13:09:35 UTC 2023


On Wed, 28 Jun 2023 08:59:17 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert to ANY for TestAutoVectorization2DArray.java
>
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/IREncodingParser.java line 49:
> 
>> 47:     private static final Pattern IR_ENCODING_PATTERN =
>> 48:             Pattern.compile("(?<=" + IREncodingPrinter.START + "\r?\n).*\\R([\\s\\S]*)(?=" + IREncodingPrinter.END + ")");
>> 49:     private static final Pattern VMINFO_PATTERN =
> 
> Suggestion:
> 
>     private static final Pattern VM_INFO_PATTERN =

As for splitting the VM info printing to a separate class, I also suggest to split the VM info parsing into a separate class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1245045543


More information about the hotspot-compiler-dev mailing list