RFR: 8310308: IR Framework: check for type and size of vector nodes [v5]

Emanuel Peter epeter at openjdk.org
Thu Jun 29 13:55:54 UTC 2023


On Wed, 28 Jun 2023 08:01:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   TestBadFormat.java and TestVectorNode.java are in good state now
>
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/IRRule.java line 51:
> 
>> 49:         this.ruleId = ruleId;
>> 50:         this.irAnno = irAnno;
>> 51:         this.matcher = new MatchableMatcher(new CompilePhaseIRRuleBuilder(irAnno, compilation).build(vmInfo));
> 
> For consistency, I would move `vmInfo` directly into the `CompilePhaseIRRuleBuilder` constructor.

For consistency with what exactly? How would I pass it on/down from the `CompilePhaseIRRuleBuilder` constructor?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1246655137


More information about the hotspot-compiler-dev mailing list