RFR: 8310308: IR Framework: check for type and size of vector nodes [v2]
Christian Hagedorn
chagedorn at openjdk.org
Thu Jun 29 14:49:02 UTC 2023
On Thu, 29 Jun 2023 13:50:16 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/c2/TestMinMaxSubword.java line 64:
>>
>>> 62: // should not generate vectorized Min/Max nodes for them.
>>> 63: @Test
>>> 64: @IR(failOn = {IRNode.MIN_VI, IRNode.MIN_VF, IRNode.MIN_VD})
>>
>> We could think about keeping generic vector nodes that match any type and restrict their usage to `failOn` constraints.
>
> I'm not sure it is worth it now. There are very few use cases, this is one of them.
Okay, if there are only few cases, it's fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1246726774
More information about the hotspot-compiler-dev
mailing list