RFR: 8310308: IR Framework: check for type and size of vector nodes [v2]

[Emanuel Peter]

On Fri, 30 Jun 2023 08:32:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 249:
>> 
>>> 247:     public static final String ADD_REDUCTION_VD = PREFIX + "ADD_REDUCTION_VD" + POSTFIX;
>>> 248:     static {
>>> 249:         beforeMatchingNameRegex(ADD_REDUCTION_VD, "AddReductionVD");
>> 
>> Shouldn't add reduction nodes only be created in Superword?
>
> Actually, the Vector API can also generate these nodes, and then they would already exist at parsing. I wanted to make these nodes vectorNodes as well, but they do not have a vector output, only a vector input. Hence I cannot match their size.
> We currently do not have any reduction IR tests for the Vector API. I tracked it in [JDK-8310523](https://bugs.openjdk.org/browse/JDK-8310523).
> 
> Actually, the reduction nodes are the only `superWordNodes`. I think we can eventually remove `superWordNodes` completely.

Still, I reverted them to `superWordNodes` for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1247602749