RFR: 8310308: IR Framework: check for type and size of vector nodes [v2]

[Emanuel Peter]

On Wed, 28 Jun 2023 12:35:16 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert to ANY for TestAutoVectorization2DArray.java
>
> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 2250:
> 
>> 2248:             int s = 0;
>> 2249:             try {
>> 2250:                 s = Integer.parseInt(sizes[i]);
> 
> We should also check if the size is a reasonable number (i.e. a positive multiple of 2 and maybe an upper limit(?)) and report a format violation if that is not the case as for example in:
> 
> @IR(counts = {IRNode.ADD_VI, IRNode.VECTOR_SIZE + "3,-2", "1"})

I'm reporting an error on negative numbers now. But I'm not sure I want to limit it to power of 2 or a size limit. Especially when uses flags/tags this could not always hold.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1247656570