RFR: 8303147: [s390x] fast & slow debug builds are broken
Kim Barrett
kbarrett at openjdk.org
Fri Mar 3 20:30:12 UTC 2023
On Thu, 2 Mar 2023 10:06:17 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
> This PR fixes broken fast debug and slow debug build for s390x-arch. tier1 test are completed and results are not affect after this patch.
src/hotspot/cpu/aarch64/c1_Defs_aarch64.hpp line 93:
> 91: enum {
> 92: pd_reserved_argument_area_size_factor = 2
> 93: };
[Not a review, just a drive-by comment.]
Please don't use enums to define constants like this. This is an old and obsolete style that shouldn't be
used any more. Quoting from the HotSpot Style Guide:
"Due to bugs in certain (very old) compilers, there is widespread use of enums and avoidance of in-class initialization of static integral constant members. Compilers having such bugs are no longer supported. Except where an enum is semantically appropriate, new code should use integral constants."
-------------
PR: https://git.openjdk.org/jdk/pull/12825
More information about the hotspot-compiler-dev
mailing list