RFR: 8303147: [s390x] fast & slow debug builds are broken

[Amit Kumar]

On Sat, 4 Mar 2023 01:27:36 GMT, SUN Guoyun <duke at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/c1_Defs_aarch64.hpp line 93:
>> 
>>> 91: enum {
>>> 92:   pd_reserved_argument_area_size_factor = 2
>>> 93: };
>> 
>> [Not a review, just a drive-by comment.]
>> Please don't use enums to define constants like this.  This is an old and obsolete style that shouldn't be
>> used any more.  Quoting from the HotSpot Style Guide:
>> "Due to bugs in certain (very old) compilers, there is widespread use of enums and avoidance of in-class initialization of static integral constant members. Compilers having such bugs are no longer supported. Except where an enum is semantically appropriate, new code should use integral constants."
>
> @kimbarrett Where to see `HotSpot Style Guide`, can you give a URL link?

@sunny868 here: https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md

-------------

PR: https://git.openjdk.org/jdk/pull/12825