RFR: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted [v4]

Doug Simon dnsimon at openjdk.org
Wed Mar 8 11:04:26 UTC 2023


On Wed, 8 Mar 2023 10:54:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8299570
>>  - changed return type of NativeCall::trampoline_jump to void
>>  - try rationalize code in NativeCall::trampoline_jump
>>  - properly handle CodeBuffer exhaustion in JVMCI backend
>
> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 548:
> 
>> 546:     }
>> 547:   } else {
>> 548:     // If not using far branches, patch this call directly to dest.
> 
> This is all very complicated.  Can't we just add `JVMCI_ERROR`s where we need them?

I'm not following - isn't this exactly what the code is doing? Maybe you could demonstrate how you think it should look.

-------------

PR: https://git.openjdk.org/jdk/pull/11945


More information about the hotspot-compiler-dev mailing list