RFR: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted [v4]
Andrew Haley
aph at openjdk.org
Wed Mar 8 11:04:27 UTC 2023
On Wed, 8 Mar 2023 10:59:35 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 548:
>>
>>> 546: }
>>> 547: } else {
>>> 548: // If not using far branches, patch this call directly to dest.
>>
>> This is all very complicated. Can't we just add `JVMCI_ERROR`s where we need them?
>
> I'm not following - isn't this exactly what the code is doing? Maybe you could demonstrate how you think it should look.
Maybe it would be nicer to get the `! far_branches` code path out of the way first, and return immediately.
-------------
PR: https://git.openjdk.org/jdk/pull/11945
More information about the hotspot-compiler-dev
mailing list