RFR: 8303611: Null pointer dereference in block.hpp:586 (ID: 44856)

Fri Mar 10 07:36:13 UTC 2023

On Wed, 8 Mar 2023 08:51:46 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Replaced `unique_ctrl_out_or_null` with `unique_ctrl_out`, which asserts if it finds `nullptr`. This is better than running into a `nullptr`-dereference inside `get_block_for_node`.
> 
> This was found by a static code analyzer, so it is not clear that a `nullptr` dereference would ever happen. But let's still fix it.

Looks good to me too but please verify that the static analysis now passes.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12919