RFR: 8303951: Add asserts before record_method_not_compilable where possible [v4]

[Tobias Hartmann]

On Wed, 22 Mar 2023 13:16:20 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I went through all `C2` bailouts, and checked if they are justified to bail out of compilation silently. I added asserts everywhere. Those that were hit, I inspected by hand.
>> 
>> Some of them seem to be justified. There I added comments why they are justified. They are cases that we do not want to handle in `C2`, and that are rare enough so that it probably does not matter.
>> 
>> For the following bailouts I did not add an assert, because it may have revealed a bug:
>> [JDK-8304328](https://bugs.openjdk.org/browse/JDK-8304328) C2 Bailout "failed spill-split-recycle sanity check" reveals hidden issue with RA
>> 
>> Note:
>> [JDK-8303466](https://bugs.openjdk.org/browse/JDK-8303466) C2: COMPILE SKIPPED: malformed control flow - only one IfProj
>> That bug bug was the reason for this RFE here. I added the assert for "malformed control flow". After this RFE here, that Bug will run into the assert on debug builds.
>> 
>> I ran `tier1-6` and stress testing. Now running `tier7-9`.
>> 
>> Filed a follow-up RFE to do the same for `BAILOUT` in `C1`: [JDK-8304532](https://bugs.openjdk.org/browse/JDK-8304532).
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove some of my bad comments

Thanks for making these changes, looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13038#pullrequestreview-1353977437