RFR: JDK-8302644: IGV: Apply filters per graph tab and not globally [v9]

Tobias Holenstein tholenstein at openjdk.org
Wed Mar 29 10:29:52 UTC 2023


On Wed, 29 Mar 2023 09:11:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix: update checkboxes when switching filter profiles
>>   
>>   based on feedback from @chhagedorn
>
> src/utils/IdealGraphVisualizer/FilterWindow/src/main/java/com/sun/hotspot/igv/filterwindow/FilterTopComponent.java line 352:
> 
>> 350:     }
>> 351: 
>> 352:     public void addFilter(CustomFilter cf) {
> 
> While at it, you could rename `cf` and `fo` to something more descriptive like `customFilter` and `fileObject`.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12714#discussion_r1151720378


More information about the hotspot-compiler-dev mailing list