RFR: JDK-8302644: IGV: Apply filters per graph tab and not globally [v9]

Tobias Holenstein tholenstein at openjdk.org
Wed Mar 29 10:38:42 UTC 2023


On Wed, 29 Mar 2023 09:14:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix: update checkboxes when switching filter profiles
>>   
>>   based on feedback from @chhagedorn
>
> src/utils/IdealGraphVisualizer/Util/src/main/java/com/sun/hotspot/igv/util/RangeSliderModel.java line 49:
> 
>> 47: 
>> 48:     public RangeSliderModel(RangeSliderModel model) {
>> 49:         this();
> 
> I suggest to directly initialize the missing fields (`changedEvent` and `colorChangedEvent`) instead of initializing the other fields twice with `this()`.

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/EditorTopComponent.java line 379:
> 
>> 377:     }
>> 378: 
>> 379:     private boolean useBoldDisplayName = false;
> 
> Should be moved up to the other fields

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12714#discussion_r1151731569
PR Review Comment: https://git.openjdk.org/jdk/pull/12714#discussion_r1151727317


More information about the hotspot-compiler-dev mailing list