RFR: JDK-8302644: IGV: Apply filters per graph tab and not globally [v12]
Tobias Holenstein
tholenstein at openjdk.org
Wed Mar 29 10:38:46 UTC 2023
On Wed, 29 Mar 2023 09:19:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Tobias Holenstein has updated the pull request incrementally with six additional commits since the last revision:
>>
>> - add missing empty line
>> - Merge branch 'JDK-8302644' of github.com:tobiasholenstein/jdk into JDK-8302644
>> - Update src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/EditorTopComponent.java
>>
>> remove empty line
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - init fields directly in RangeSliderModel constructor
>> - move useBoldDisplayName to fields
>> - make group final again
>
> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/DiagramViewModel.java line 163:
>
>> 161: showNodeHull = true;
>> 162: showEmptyBlocks = true;
>> 163: group = graph.getGroup();
>
> You could keep that to make `group` `final` again and then just initialize it in `init()` (or `initGroup()`) by directly accessing the field.
good idea - done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12714#discussion_r1151726052
More information about the hotspot-compiler-dev
mailing list