RFR: 8305189: C2 failed "assert(_outcnt==1) failed: not unique" [v2]

[Roland Westrelin]

On Wed, 10 May 2023 16:09:13 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/loopnode.cpp line 6180:
> 
>> 6178: 
>> 6179:   if (!_verify_only && n->Opcode() == Op_OpaqueZeroTripGuard) {
>> 6180:     _zero_trip_guard_opaque_nodes.push(n);
> 
> That's a good idea to collect them newly here for each loop opts pass.

I'm not sure if you're expecting me to comment on this or not.

> src/hotspot/share/opto/opaquenode.cpp line 58:
> 
>> 56: }
>> 57: 
>> 58: CountedLoopNode* OpaqueZeroTripGuardNode::guarded_loop() const {
> 
> Could be guarded with `ifdef ASSERT` since you are only using it for an assertion.

I made that change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13901#discussion_r1190781947
PR Review Comment: https://git.openjdk.org/jdk/pull/13901#discussion_r1190781227