RFR: 8305189: C2 failed "assert(_outcnt==1) failed: not unique" [v2]

[Christian Hagedorn]

On Thu, 11 May 2023 08:01:02 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/loopnode.cpp line 6180:
>> 
>>> 6178: 
>>> 6179:   if (!_verify_only && n->Opcode() == Op_OpaqueZeroTripGuard) {
>>> 6180:     _zero_trip_guard_opaque_nodes.push(n);
>> 
>> That's a good idea to collect them newly here for each loop opts pass.
>
> I'm not sure if you're expecting me to comment on this or not.

No action required. I was first trying to suggest to move it to `Compile` to the other predicate opaque node lists but then I've thought that this solution here is cleaner. So it was more of a 👍 (I will refactor these predicate lists in the assertion predicate changes - otherwise, I would have suggested to move them here as well at some point).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13901#discussion_r1190792057