RFR: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712

Tobias Hartmann thartmann at openjdk.org
Fri May 12 14:29:03 UTC 2023


On Tue, 9 May 2023 13:02:45 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

> - The `finalize()` method is replaced with `cleanup()`. 
> - A new constructor is added to register the cleanup method.
> - A static `Cleaner` is defined to have only one cleaner thread for all the 15000 instances. Otherwise, we get an `OutOfMemoryException` on cleaner thread creation.

The fix looks good to me. Not sure though how much sense that test still makes after the AOT removal but I guess keeping it does not hurt.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13886#pullrequestreview-1424619342


More information about the hotspot-compiler-dev mailing list