RFR: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
Afshin Zafari
azafari at openjdk.org
Fri May 12 14:29:06 UTC 2023
On Thu, 11 May 2023 12:34:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> - The `finalize()` method is replaced with `cleanup()`.
>> - A new constructor is added to register the cleanup method.
>> - A static `Cleaner` is defined to have only one cleaner thread for all the 15000 instances. Otherwise, we get an `OutOfMemoryException` on cleaner thread creation.
>
> I think this looks good, and still tests what the original test failure was. Unless the bug was with the _return_register_finalizer bytecode, but I don't think that's the case.
Thank you @coleenp and @TobiHartmann for your comments.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13886#issuecomment-1545830843
More information about the hotspot-compiler-dev
mailing list