RFR: 8051725: Improve expansion of Conv2B nodes in the middle-end [v7]

[Quan Anh Mai]

On Thu, 18 May 2023 14:33:37 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes from code review
>
> src/hotspot/share/opto/addnode.cpp line 892:
> 
>> 890:   // Propagate xor through constant cmoves. This pattern can occur after expansion of Conv2B nodes.
>> 891:   if (in1->Opcode() == Op_CMoveI && in2->is_Con()) {
>> 892:     if (in1->in(2)->is_Con() && in1->in(3)->is_Con()) {
> 
> `CMoveNode::IfTrue` and `CMoveNode::IfFalse` instead of 3 and 2.

`CMoveNode::Condition` instead of `in1->in(1)` below, too. You need to check for the node actually being a `BoolNode` in case a constant-condition `CMove` has not been folded yet.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13345#discussion_r1197908427