RFR: 8308465: Reduce memory reads in AArch64 MD5 intrinsic [v2]
Yi-Fan Tsai
duke at openjdk.org
Sat May 20 20:11:53 UTC 2023
On Sat, 20 May 2023 10:03:32 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename and optimize
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 3458:
>
>> 3456: RegSet saved_regs = RegSet::range(r16, r22) - r18_tls;
>> 3457: Cached64Bytes reg_cache(_masm, buf, RegSet::of(r14, r15) + saved_regs);
>> 3458:
>
> Perhaps add a note here to the effect that the rest of this patch requires there to be **exactly** 8 registers in this set. Maybe assert that here?
This requirement has been asserted in the constructor.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14068#discussion_r1199654480
More information about the hotspot-compiler-dev
mailing list