RFR: 8308465: Reduce memory reads in AArch64 MD5 intrinsic [v2]

[Andrew Haley]

On Sat, 20 May 2023 20:07:01 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 3458:
>> 
>>> 3456:     RegSet saved_regs = RegSet::range(r16, r22) - r18_tls;
>>> 3457:     Cached64Bytes reg_cache(_masm, buf, RegSet::of(r14, r15) + saved_regs);
>>> 3458: 
>> 
>> Perhaps add a note here to the effect that the rest of this patch requires there to be **exactly** 8 registers in this set. Maybe assert that here?
>
> This requirement has been asserted in the constructor.

Sure, but a note here would have made it easier to understand.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14068#discussion_r1199730360