RFR: 8051725: Improve expansion of Conv2B nodes in the middle-end [v7]

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Tue May 23 07:09:45 UTC 2023


On Thu, 18 May 2023 14:34:27 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes from code review
>
> src/hotspot/share/opto/addnode.cpp line 900:
> 
>> 898: 
>> 899:       if (cmp_op == Op_CmpI || cmp_op == Op_CmpP) {
>> 900:         // Flip the sense of comparison in the bool and return a new cmove
> 
> Mistaken comment

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13345#discussion_r1201643599


More information about the hotspot-compiler-dev mailing list