RFR: 8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out [v2]

[Tom Rodriguez]

On Fri, 26 May 2023 19:56:56 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR makes TestUncaughtErrorInCompileMethod more robust against HotSpot compilation scheduling variability which should prevent timeouts in this test.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   [skip ci] replace File with static boolean for communicating between app and compiler threads

Marked as reviewed by never (Reviewer).

test/hotspot/jtreg/compiler/jvmci/TestUncaughtErrorInCompileMethod.java line 70:

> 68:             int total = 0;
> 69:             while (!compilerCreationErrorOccurred) {
> 70:                 total += getTime();

This summing is weird since it's adding currentTimeMillis each time.  Aren't you just trying to report how long it waited, which would just be end - start.  Also having a sleep here so it isn't simply spinning wouldn't hurt.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14173#pullrequestreview-1446872122
PR Review Comment: https://git.openjdk.org/jdk/pull/14173#discussion_r1207279983