RFR: 8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out [v2]

[Doug Simon]

On Fri, 26 May 2023 20:01:17 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   [skip ci] replace File with static boolean for communicating between app and compiler threads
>
> test/hotspot/jtreg/compiler/jvmci/TestUncaughtErrorInCompileMethod.java line 70:
> 
>> 68:             int total = 0;
>> 69:             while (!compilerCreationErrorOccurred) {
>> 70:                 total += getTime();
> 
> This summing is weird since it's adding currentTimeMillis each time.  Aren't you just trying to report how long it waited, which would just be end - start.  Also having a sleep here so it isn't simply spinning wouldn't hurt.

I'm not really trying to report anything related to timing. I just need this loop to do some work that triggers JVMCI compilation. I'm open to better suggestions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14173#discussion_r1207285520