RFR: 8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out [v2]

[Tom Rodriguez]

On Fri, 26 May 2023 20:05:22 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/jvmci/TestUncaughtErrorInCompileMethod.java line 70:
>> 
>>> 68:             int total = 0;
>>> 69:             while (!compilerCreationErrorOccurred) {
>>> 70:                 total += getTime();
>> 
>> This summing is weird since it's adding currentTimeMillis each time.  Aren't you just trying to report how long it waited, which would just be end - start.  Also having a sleep here so it isn't simply spinning wouldn't hurt.
>
> I'm not really trying to report anything related to timing. I just need this loop to do some work that triggers JVMCI compilation. I'm open to better suggestions.

A comment explaining that it's useless work to trigger a compilation would be help then.  The work doesn't really matter.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14173#discussion_r1207306633