RFR: 8319184: RISC-V: improve MD5 intrinsic [v2]
Antonios Printezis
tonyp at openjdk.org
Fri Nov 3 18:23:06 UTC 2023
On Wed, 1 Nov 2023 17:14:49 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
>>
>> changes based on code review
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3967:
>
>> 3965: // a += ac
>> 3966: __ mv(rtmp3, t);
>> 3967: __ addw(a, a, rtmp3);
>
> Could these 2 lines could be replaced with addiw? although no performance gain, but could be simpler.
The constants are too big for a single `addiw` instruction. So, it will be translated to this form anyway.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16453#discussion_r1382077293
More information about the hotspot-compiler-dev
mailing list