RFR: 8319184: RISC-V: improve MD5 intrinsic [v2]

Hamlin Li mli at openjdk.org
Sun Nov 5 11:35:06 UTC 2023


On Fri, 3 Nov 2023 18:20:05 GMT, Antonios Printezis <tonyp at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3967:
>> 
>>> 3965:     // a += ac
>>> 3966:     __ mv(rtmp3, t);
>>> 3967:     __ addw(a, a, rtmp3);
>> 
>> Could these 2 lines could be replaced with addiw? although no performance gain, but could be simpler.
>
> The constants are too big for a single `addiw` instruction. So, it will be translated to this form anyway.

Yes, but code would be simpler?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16453#discussion_r1382557288


More information about the hotspot-compiler-dev mailing list