RFR: 8316592: RISC-V: implement poly1305 intrinsic [v7]
Hamlin Li
mli at openjdk.org
Mon Nov 6 19:02:50 UTC 2023
On Mon, 6 Nov 2023 18:32:57 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> null has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move wide_madd and wide_mul to macroAssembler_riscv
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4578:
>
>> 4576: __ cad(U_1, U_1, t2, t2); // Add carry to U_1 with carry output to t2
>> 4577: __ andi(U_2, U_2, bits2);
>> 4578: __ add(U_2, U_2, t2); // Add carry to U_2
>
> What happens if U_2 == 0b11 and t2 == 1? Is it possible?
> If it's possible, do we need another (and final) reduce?
Maybe there is no chance for this to happen, as in the loop there is already one reducing before quit the loop, the `reduce` here is already the final one?
I'm not quite sure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1383797387
More information about the hotspot-compiler-dev
mailing list