RFR: 8316592: RISC-V: implement poly1305 intrinsic [v8]
Vladimir Kempik
vkempik at openjdk.org
Tue Nov 7 19:47:13 UTC 2023
On Tue, 7 Nov 2023 16:24:34 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:
>> ArsenyBochkarev has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Move reduce block to standalone function
>> - Add different registers assert
>> - Remove unnecessary registers recycling
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4839:
>
>> 4837: }
>> 4838:
>> 4839: if (UsePoly1305Intrinsics) {
>
> Why is it in the `#ifdef COMPILER2` block? What's the dependency on C2? If it's not necessary, you can move it to https://github.com/openjdk/jdk/pull/16417/files?diff=unified&w=0#diff-97f199af6d1c8c17b2fa4f50eb1bbc0081858cc59a899f32792a2d31f933ccc4R4861.
So far this intrinsic can be used by C2 only, so it's clever to not compile this code if we build jdk without c2.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1385469057
More information about the hotspot-compiler-dev
mailing list