RFR: JDK-8283140: Remove unused encoding classes/operands from x86_64.ad [v3]

[Dean Long]

On Fri, 27 Oct 2023 21:32:46 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> These encoding classes became dead code when the instructions' definitions were patched to use the MacroAssembler.
>> 
>> Tested with tier 1-3 on Linux, Windows & MacOS.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

src/hotspot/cpu/x86/x86_64.ad line 818:

> 816: 
> 817:   if (framesize) {
> 818:     __ addq(as_Register(RSP_enc), framesize);

Suggestion:

    __ addq(rsp, framesize);

src/hotspot/cpu/x86/x86_64.ad line 821:

> 819:   }
> 820: 
> 821:   __ popq(as_Register(RBP_enc));

Suggestion:

  __ popq(rbp);

src/hotspot/cpu/x86/x86_64.ad line 1460:

> 1458: 
> 1459:   MacroAssembler masm(&cbuf);
> 1460:   masm.lea(as_Register(reg), Address(as_Register(RSP_enc), offset));

Suggestion:

  masm.lea(as_Register(reg), Address(rsp, offset));

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1386052154
PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1386052780
PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1386053952