RFR: 8319748: [JVMCI] TestUseCompressedOopsFlagsWithUlimit.java crashes on libgraal [v2]

Tobias Hartmann thartmann at openjdk.org
Thu Nov 9 06:21:56 UTC 2023


On Wed, 8 Nov 2023 22:32:11 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> The memory allocated in libjvmci for the error message describing a failure in `JNI_CreateJavaVM` must not be freed with `os::free` as the allocation was not NMT-aware.
>
> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8319748
>  - do not use os::free for memory allocated in libjvmci

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16571#pullrequestreview-1721783433


More information about the hotspot-compiler-dev mailing list