RFR: 8319747: galoisCounterMode_AESCrypt stack walking broken [v2]
Daniel Jeliński
djelinski at openjdk.org
Tue Nov 14 08:05:56 UTC 2023
> This PR fixes stack walking by removing incorrect RBP change in the middle of a stub.
>
> I also changed the register assignment to avoid saving RSI on Windows.
>
> Testing:
> - test/hotspot/jtreg/compiler/codegen/aes/TestAESMain.java still passes, both on Windows and Linux
> - mach5 tier1-2 (including security and TLS-heavy networking tests) still pass
> - the generated flamegraphs (attached in JBS) show the correct stack trace with this fix
Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
Revert register renaming
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16567/files
- new: https://git.openjdk.org/jdk/pull/16567/files/632f5c18..237abb92
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16567&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16567&range=00-01
Stats: 11 lines in 1 file changed: 6 ins; 0 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/16567.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16567/head:pull/16567
PR: https://git.openjdk.org/jdk/pull/16567
More information about the hotspot-compiler-dev
mailing list