RFR: 8319747: galoisCounterMode_AESCrypt stack walking broken [v2]

[Sandhya Viswanathan]

On Tue, 14 Nov 2023 08:05:56 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> This PR fixes stack walking by removing incorrect RBP change in the middle of a stub.
>> 
>> I also changed the register assignment to avoid saving RSI on Windows.
>> 
>> Testing:
>> - test/hotspot/jtreg/compiler/codegen/aes/TestAESMain.java still passes, both on Windows and Linux
>> - mach5 tier1-2 (including security and TLS-heavy networking tests) still pass
>> - the generated flamegraphs (attached in JBS) show the correct stack trace with this fix
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert register renaming

Looks good to me.

-------------

Marked as reviewed by sviswanathan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16567#pullrequestreview-1730092674