RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v15]

Daniel Lundén duke at openjdk.org
Tue Nov 14 09:12:46 UTC 2023


On Tue, 14 Nov 2023 08:21:10 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in comment
>
> src/hotspot/share/opto/node.hpp line 1657:
> 
>> 1655:     else {
>> 1656:       // Not a boundary node, continue search
>> 1657:       for (DUIterator_Fast kmax, k = use->fast_outs(kmax); k < kmax; k++)
> 
> (optional) You could `test_set` here, then you could avoid pushing them multiple times.

Thanks for the suggestion, sounds good to me. Updated now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1392237785


More information about the hotspot-compiler-dev mailing list