RFR: 8316592: RISC-V: implement poly1305 intrinsic [v9]

ArsenyBochkarev duke at openjdk.org
Tue Nov 14 15:21:00 UTC 2023


On Tue, 14 Nov 2023 09:03:11 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Oh, I missed it, thanks! However, it doesn't affect much, as far as I can see:
>> in `adc(U_2, U_2, U_1HI, t1)` register `t1` is `0b1` max, so the max for `U_2` is `0b10000` --> in `poly1305_reduce` the `tmp1` max is `0b100`. Multiplying it by `0b101` we get `0b10100`, which is still ok. Or am I missing something here?
>
> Are there any restrictions on the value of U_1HI?

Ohh, it looks like I completely missed the `U_1HI` too, sorry. Let's do a two-step reduce then

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1392763210


More information about the hotspot-compiler-dev mailing list