RFR: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp [v3]

[Emanuel Peter]

On Mon, 20 Nov 2023 14:33:11 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> src/hotspot/share/compiler/directivesParser.cpp line 343:
>> 
>>> 341:           valid = validator.is_valid();
>>> 342:           if (valid) {
>>> 343:             set->set_ideal_phase_mask(validator);
>> 
>> Why not pass it the mask directly?
>
> Do you mean extracting the mask from the validator and then passing it to `set_ideal_phase_mask`? Isn't it simpler to just pass the validator and then handle it internally in `set_ideal_phase_mask`?
> 
> I've also renamed the above after Roberto's suggestion, so it's now:
> 
> set->set_ideal_phase_name_set(validator);

Yes, extract the mask/set first, and pass it directly. There is no need for `set_ideal_phase_name_set` to get more than it asks for as input.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1400147606