RFR: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp [v4]

Daniel Lundén duke at openjdk.org
Tue Nov 21 09:39:21 UTC 2023


On Tue, 21 Nov 2023 07:49:25 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Do you mean extracting the mask from the validator and then passing it to `set_ideal_phase_mask`? Isn't it simpler to just pass the validator and then handle it internally in `set_ideal_phase_mask`?
>> 
>> I've also renamed the above after Roberto's suggestion, so it's now:
>> 
>> set->set_ideal_phase_name_set(validator);
>
> Yes, extract the mask/set first, and pass it directly. There is no need for `set_ideal_phase_name_set` to get more than it asks for as input.

OK, fine with me. Now changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1400280931


More information about the hotspot-compiler-dev mailing list