RFR: 8313438: [s390x] build broken after JDK-8301996 [v3]

Martin Doerr mdoerr at openjdk.org
Fri Oct 6 23:25:36 UTC 2023


On Fri, 6 Oct 2023 21:50:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adds suggestions
>
> src/hotspot/cpu/s390/templateTable_s390.cpp line 3229:
> 
>> 3227:   NearLabel notVolatile;
>> 3228: 
>> 3229:   if (!flags.is_volatile()) {
> 
> This change is not legal. The property of the flag register has nothing to do with the bit in the content.

Ahh. Wait. We just use the z_fence if the flags register was possibly killed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15885#discussion_r1349379971


More information about the hotspot-compiler-dev mailing list