RFR: 8282365: Optimize divideUnsigned and remainderUnsigned for constants [v18]

Emanuel Peter epeter at openjdk.org
Tue Oct 10 09:27:23 UTC 2023


On Fri, 6 Oct 2023 17:51:47 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> @merykitty another way to easily get a value range it to use a `Phi` node which merges two constants. Have you tried that?
>> 
>> long x;
>> if (flag) {
>>   x = 10;
>> } else {
>>   x = 100;
>> }
>> // Phi for x should have range long:10..100
>
> @eme64 Thanks for your reviews, I have addressed those.

@merykitty One test is still failing:
`compiler/integerArithmetic/DivisionByConstant.java`
I see this in the logs:
`IR verification disabled due to using non-whitelisted JTreg VM or Javaoptions flag(s).`
And then your assert triggers because we do not trigger the `IRViolationException`:
`java.lang.RuntimeException: Expected exception not thrown`

-------------

PR Comment: https://git.openjdk.org/jdk/pull/9947#issuecomment-1754802953


More information about the hotspot-compiler-dev mailing list