RFR: 8282365: Optimize divideUnsigned and remainderUnsigned for constants [v18]
Quan Anh Mai
qamai at openjdk.org
Tue Oct 10 13:51:23 UTC 2023
On Tue, 10 Oct 2023 09:24:11 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> @eme64 Thanks for your reviews, I have addressed those.
>
> @merykitty One test is still failing:
> `compiler/integerArithmetic/DivisionByConstant.java`
> I see this in the logs:
> `IR verification disabled due to using non-whitelisted JTreg VM or Javaoptions flag(s).`
> And then your assert triggers because we do not trigger the `IRViolationException`:
> `java.lang.RuntimeException: Expected exception not thrown`
>
> Maybe we just remove this verification function. I'm not sure it is worth it. As you said, you have other positive tests where we have IR rules that look for presence of `DIV` etc.
@eme64 I see, it seems the test is run at higher tiers with additional flags, I have removed the negative method.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/9947#issuecomment-1755465628
More information about the hotspot-compiler-dev
mailing list