RFR: 8313438: [s390x] build broken after JDK-8301996 [v4]

Martin Doerr mdoerr at openjdk.org
Wed Oct 11 08:36:15 UTC 2023


On Wed, 11 Oct 2023 05:09:48 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   uses assert instead of if-statement
>
> src/hotspot/cpu/s390/templateTable_s390.cpp line 280:
> 
>> 278: 
>> 279:   if (JvmtiExport::can_post_breakpoint()) {
>> 280:     NearLabel L_fast_patch;
> 
> Hi @RealLucy , @TheRealMDoerr 
> 
> Do you suggest to revert it back, so that situation like [JDK-8317851](https://bugs.openjdk.org/browse/JDK-8317851), could be avoided ? 
> 
> Thanks,

No.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15885#discussion_r1354406140


More information about the hotspot-compiler-dev mailing list