RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v4]
iaroslavski
duke at openjdk.org
Wed Oct 11 20:13:17 UTC 2023
On Wed, 11 Oct 2023 19:56:47 GMT, Srinivas Vamsi Parasa <duke at openjdk.org> wrote:
> > > > Also @forceinline in these changes only works for case when new intrinsics are not used. I would suggest to adapt/update JMH benchmark to cover all cases and see effect @forceinline without intrinsics. That will tell us which @forceinline annotations are needed.
> > >
> > >
> > > Added `@ForceInline` annotations to `insertionSort` and `mixedInsertionSort` as it is helping arrays of small sizes when intrinsics are disabled.
> > > Thanks, Vamsi
> >
> >
> > @vamsi-parasa Please revert changes (adding @forceinline to insertionSort and mixedInsertionSort) - I checked: initinal version works faster.
>
> @iaroslavski Vladimir, have you used `-XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_arraySort,_arrayPartition` to disable the intrinsics? Also, it helps to have one warmup iteration of 30 secs to reduce run-to-run variance.
@vamsi-parasa
Yes, I tried with the disabled mentioned intrinsics.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16124#issuecomment-1758458948
More information about the hotspot-compiler-dev
mailing list